-
...is set to http://www.openplans.org/theme.html by default after fassembling deliverance. As a result you have to go in and change it by hand after building an nycstreets stack. And I believe each time deliverance is hit through a new hostname, it uses this as the default theme_uri for the new host it creates. Is this a configurable setting? If so, it strikes me that the requirements profile would be a good place to put what the theme_uri should be, fassembler could pass it into deliverance. Even better would be if the requirements profile could point to the url of a static theme file, and deliverance would automatically put this file in the static directory of each new host it creates, and set theme_uri to point to it. Or is there already a provision for doing this I don't know about? Josh
- Thread Outline:
-
Joshua Bronson wrote: > ...is set to http://www.openplans.org/theme.html by default after > fassembling deliverance. As a result you have to go in and change it by > hand after building an nycstreets stack. And I believe each time > deliverance is hit through a new hostname, it uses this as the default > theme_uri for the new host it creates. Is this a configurable setting? > If so, it strikes me that the requirements profile would be a good place > to put what the theme_uri should be, fassembler could pass it into > deliverance. Even better would be if the requirements profile could > point to the url of a static theme file, and deliverance would > automatically put this file in the static directory of each new host it > creates, and set theme_uri to point to it. Or is there already a > provision for doing this I don't know about? The setting is default_theme_uri in the deliverance.ini (the ini file template itself is in dvhoster). Your suggestion that it comes from env.req_settings.get('default_theme_uri', 'http://www.openplans.org/theme.html') seems good. I thought at one point theme_uri was by default pointing to /theme.html, and that file was copied in place. But that was a problem as well, as then with lots of copies of the theme file you couldn't update it without updating everything else. It seems more ideal if everything by default gets a single URI (that is local to the site) and if you want to edit the theme the first step would be to copy that file to someplace local (but for unedited themes there would only be one file to update). So I think there is some provision already, but I'm not sure it's a good idea. Ian-
On Fri, Feb 15, 2008 at 2:30 PM, Ian Bicking <ianb@...> wrote: > Joshua Bronson wrote: > > ...is set to http://www.openplans.org/theme.html by default after > > fassembling deliverance. As a result you have to go in and change it by > > hand after building an nycstreets stack. And I believe each time > > deliverance is hit through a new hostname, it uses this as the default > > theme_uri for the new host it creates. Is this a configurable setting? > > If so, it strikes me that the requirements profile would be a good place > > to put what the theme_uri should be, fassembler could pass it into > > deliverance. Even better would be if the requirements profile could > > point to the url of a static theme file, and deliverance would > > automatically put this file in the static directory of each new host it > > creates, and set theme_uri to point to it. Or is there already a > > provision for doing this I don't know about? > > The setting is default_theme_uri in the deliverance.ini (the ini file > template itself is in dvhoster). Your suggestion that it comes from > env.req_settings.get('default_theme_uri', > 'http://www.openplans.org/theme.html') seems good. > > I thought at one point theme_uri was by default pointing to /theme.html, > and that file was copied in place. But that was a problem as well, as > then with lots of copies of the theme file you couldn't update it > without updating everything else. It seems more ideal if everything by > default gets a single URI (that is local to the site) and if you want to > edit the theme the first step would be to copy that file to someplace > local (but for unedited themes there would only be one file to update). > So I think there is some provision already, but I'm not sure it's a > good idea. > > Ian I've created a ticket <http://trac.openplans.org/openplans/ticket/2436> for this and added a default_them_uri setting to the appropriate deliverance-req.txt's in anticipation of its parameterization (r14118). I'd be happy to help with this if you're busy, Ian, but I'd want to go over how to do it first. Josh
-
Joshua Bronson wrote: > I've created a ticket <http://trac.openplans.org/openplans/ticket/2436> > for this and added a default_them_uri setting to the appropriate > deliverance-req.txt's in anticipation of its parameterization (r14118). > I'd be happy to help with this if you're busy, Ian, but I'd want to go > over how to do it first. I think it would just be a matter of putting default_theme_uri = {{env.req_settings.get('default_theme_uri', 'http://www.openplans.org/theme.html')}} in fassembler_config.ini_tmpl, right? At least, that's what it looks like to me. I can do this of course, but maybe you are more aware of the desired outcome/testing. Ian-
On Thu, Mar 6, 2008 at 4:54 PM, Ian Bicking <ianb@...> wrote: > Joshua Bronson wrote: > > I've created a ticket <http://trac.openplans.org/openplans/ticket/2436> > > for this and added a default_them_uri setting to the appropriate > > deliverance-req.txt's in anticipation of its parameterization (r14118). > > I'd be happy to help with this if you're busy, Ian, but I'd want to go > > over how to do it first. > > I think it would just be a matter of putting > > default_theme_uri = {{env.req_settings.get('default_theme_uri', > 'http://www.openplans.org/theme.html')}} > > in fassembler_config.ini_tmpl, right? At least, that's what it looks > like to me. I can do this of course, but maybe you are more aware of > the desired outcome/testing. > > Ian Okay, I parameterized default_theme_uri in (codespeak) r52232. Should I do something similar for the other settings (email_to, no_filter_zope, domain_regex, transcluder_ok_hosts)?
-
Joshua Bronson wrote: > On Thu, Mar 6, 2008 at 4:54 PM, Ian Bicking <ianb@... > <mailto:ianb@...>> wrote: > > Joshua Bronson wrote: > > I've created a ticket > <http://trac.openplans.org/openplans/ticket/2436> > > for this and added a default_them_uri setting to the appropriate > > deliverance-req.txt's in anticipation of its parameterization > (r14118). > > I'd be happy to help with this if you're busy, Ian, but I'd want > to go > > over how to do it first. > > I think it would just be a matter of putting > > default_theme_uri = {{env.req_settings.get('default_theme_uri', > 'http://www.openplans.org/theme.html')} > <http://www.openplans.org/theme.html')}>} > > in fassembler_config.ini_tmpl, right? At least, that's what it looks > like to me. I can do this of course, but maybe you are more aware of > the desired outcome/testing. > > Ian > > > Okay, I parameterized default_theme_uri in (codespeak) r52232. Should I > do something similar for the other settings (email_to, no_filter_zope, > domain_regex, transcluder_ok_hosts)? email_to has to be handled all over the place, and probably fixed up to be easier to handle -- right now we potentially put smtp configuration all over the place, and it would be much better if we could put it in a single file on the system since it's not something that needs per-stack configuration. I'm not sure what we really want to do with this either; each stack emails everything from all components to a single person? Maybe what I'm working on now (collecting errors via supervisor) will make this less important. no_filter_zope I think is not used. domain_regex doesn't matter for now, as we aren't doing vhosts, and we might as well leave that alone until that is clarified. I don't think transcluder_ok_hosts is useful at the moment. Or, at least, we haven't decided what to do with Transcluder generally. Ian
-
On Thu, Mar 6, 2008 at 5:22 PM, Ian Bicking <ianb@...> wrote: > Joshua Bronson wrote: > > On Thu, Mar 6, 2008 at 4:54 PM, Ian Bicking <ianb@... > > <mailto:ianb@...>> wrote: > > > > Joshua Bronson wrote: > > > I've created a ticket > > <http://trac.openplans.org/openplans/ticket/2436> > > > for this and added a default_them_uri setting to the appropriate > > > deliverance-req.txt's in anticipation of its parameterization > > (r14118). > > > I'd be happy to help with this if you're busy, Ian, but I'd want > > to go > > > over how to do it first. > > > > I think it would just be a matter of putting > > > > default_theme_uri = {{env.req_settings.get('default_theme_uri', > > 'http://www.openplans.org/theme.html')} > > <http://www.openplans.org/theme.html')}>} > > > > in fassembler_config.ini_tmpl, right? At least, that's what it > looks > > like to me. I can do this of course, but maybe you are more aware > of > > the desired outcome/testing. > > > > Ian > > > > > > Okay, I parameterized default_theme_uri in (codespeak) r52232. Should I > > do something similar for the other settings (email_to, no_filter_zope, > > domain_regex, transcluder_ok_hosts)? > > email_to has to be handled all over the place, and probably fixed up to > be easier to handle -- right now we potentially put smtp configuration > all over the place, and it would be much better if we could put it in a > single file on the system since it's not something that needs per-stack > configuration. I'm not sure what we really want to do with this either; > each stack emails everything from all components to a single person? > Maybe what I'm working on now (collecting errors via supervisor) will > make this less important. > > no_filter_zope I think is not used. > > domain_regex doesn't matter for now, as we aren't doing vhosts, and we > might as well leave that alone until that is clarified. > > I don't think transcluder_ok_hosts is useful at the moment. Or, at > least, we haven't decided what to do with Transcluder generally. > > Ian > Thanks for laying these down, Ian. I made #2436<http://trac.openplans.org/openplans/ticket/2436> backburner now that default_theme_uri is taken care of. Josh
-
-
-
-
-
-
fassembler discussion
text.html (text/html) 1 kB
text.html (text/html) 2.7 kB