-
Re. http://trac.openplans.org/openplans/ticket/2229 .... I've been fixing this incrementally, but it's in danger of always cropping up again unless we have Maker.ask do the checking of self.interactive. The problem is knowing what to do. Maybe it should just choose the default, and if default is None, raise? If we did that, then eg. http://trac.openplans.org/openplans/changeset/14235 could have been just done like so: response = self.maker.ask('build.ini is in the way of a checkout, but contains information. Delete?', default='n') -- Paul Winkler http://www.openplans.org/people/slinkp/profile yahoo: slinkp23 AIM: slinkp1970 -
Paul Winkler wrote: > Re. http://trac.openplans.org/openplans/ticket/2229 .... > I've been fixing this incrementally, but it's in danger of always > cropping up again unless we have Maker.ask do the checking of > self.interactive. > > The problem is knowing what to do. Maybe it should just choose the > default, and if default is None, raise? Yes, that sounds quite reasonable.
-
On Fri, Mar 07, 2008 at 06:54:58PM -0600, Ian Bicking wrote: > Paul Winkler wrote: >> Re. http://trac.openplans.org/openplans/ticket/2229 .... >> I've been fixing this incrementally, but it's in danger of always >> cropping up again unless we have Maker.ask do the checking of >> self.interactive. >> The problem is knowing what to do. Maybe it should just choose the >> default, and if default is None, raise? > > Yes, that sounds quite reasonable. OK, done in r2229. I looked over all the calls to .ask() to make sure they look reasonable; holler if anything breaks. (Buildbot will fire in about 90 seconds and I'll be watching it...) -- Paul Winkler http://www.openplans.org/people/slinkp/profile yahoo: slinkp23 AIM: slinkp1970
-
On Mon, Mar 10, 2008 at 12:57:10PM -0400, Paul Winkler wrote: > OK, done in r2229. Uh. That was the bug number, I meant r14297. -- Paul Winkler http://www.openplans.org/people/slinkp/profile yahoo: slinkp23 AIM: slinkp1970
-
-