On 2008-05-01 13:11, Veda Williams wrote:
> http://www.openplans.org/projects/ootb-plone-themes/qblog-test-results
>
> Sorry for the delay, I saw you released this to the collective already.
>

Hi Veda,

Thanks for testing the skin. Yes, theme is uploaded to collective. After
required changes will be done they will be committed. Below are some notes.

>3) The theme follows all new Zope3 conventions -- naming, file structure,
>etc. The site is created using ZopeSkel. PASS. Most of the skins being
>produced are installable as eggs. Will you also be supporting this?

Actually theme was created by our Skin Dump :) , but file-system structure is
the same, so I think it is OK. As for the eggs I should admit the fact that we
have no experience with it. While product works well we did not think about
another way. Though I clearly understand the superiority of the buildout
approach and we will move in that direction. I suspect this is not very
time-consuming task however I can't say when we implement this just because I
have no previous experience and can't estimate.

>7) The readme states the name of the author, contact information, compatible
>versions, and any product dependencies (ie, for tableless).
> ISSUE. You mention dropping it into the "Products" folder, which is now
> "products". Might want to change the case sensitivity there. You also need
> to state compatible Plone versions

Of course, will be changed, I suppose I could take the Jonathan's readme as a
base?

>8) The theme plays well in all of the "A" list of supported browsers:
>http://developer.yahoo.com/yui/articles/gbs/index.html excluding Windows98.
>Look for rollovers, CSS changes that might have been forgotten. Feel free to
>test additional media.
> Tested on Safari and Firefox for Mac.  "Quintagroup" is misspelled in the
> header. Personal tools do not display well - need to move them to where they
> will be visible / not covered by the searchbox. 

Thanks for this, rather strange, will be corrected.

> 10)  The site map works and is consistent with the rest of the theme.
> ISSUE: Might want to alter this area so that it takes up all three columns. 

Not sure what we expected to do on this. I will take a closer look and try to
realize.

> 17) Main template changes are kept to a minimum. If the main template has
> been changed, it should be called out in a TAL comment.  Not really sure
> what you changed here. 

Main template was changed significantly. I realize it should be covered in
Readme. We did it on the base of tableless layout from Plone 2.5, do not
remember now why we did not take it from Nuplone. Template is quite well
tested as we use it in all our custom themes.

> 19) The site should play well with the presentation styles. This is the
> "presentation mode" you see when you first install Plone 3.0. I assume it
> does if you kept base Plone styles for this. Do you want to include it as a
> link on the home page?  

Why not, have to see what should be done for this.