• OpenCore Dev

  • Calculating members' display names (Re: [OpenPlans SVN] opencore r17330)

    from darcy on May 27, 2008 12:02 PM 
    On Tue, May 27, 2008 at 11:56 AM,  <rmarianski@...> wrote:
> Author: rmarianski
> Date: 2008-05-27 11:56:39 -0400 (Tue, 27 May 2008)
> New Revision: 17330
> Log:
> Add support for new function on opencore member objects,
> "displayName". This currently shows the full name if it is set, and
> falls back to the member id.

Doesn't this already exist?  I thought there's an existing field on
member objects that is calculated to do exactly this ... though I
always forget whether it's Title, Fullname, full_name, or something
else...

egj
    Thread Outline:

  • Re: Calculating members' display names (Re: [OpenPlans SVN] opencore r17330)

    from ra on May 27, 2008 12:17 PM 
    On May 27, 2008, at 9:01 AM, Ethan Jucovy wrote:

> On Tue, May 27, 2008 at 11:56 AM,  <rmarianski@...> wrote:
>> Author: rmarianski
>> Date: 2008-05-27 11:56:39 -0400 (Tue, 27 May 2008)
>> New Revision: 17330
>> Log:
>> Add support for new function on opencore member objects,
>> "displayName". This currently shows the full name if it is set, and
>> falls back to the member id.
>
> Doesn't this already exist?  I thought there's an existing field on
> member objects that is calculated to do exactly this ... though I
> always forget whether it's Title, Fullname, full_name, or something
> else...

title is the field that should do this.  fullname is a separate field,  
which only contains the fullname, no failover to anything else... if  
it's empty it's empty.

i'm pretty sure this already works... if it doesn't, this is how it  
should be.

-r

p.s.: i thought we decided a while ago to de-emphasize the fullname  
and use the login id as the main token to display for people?  is this  
still true?

    • Re: Calculating members' display names (Re: [OpenPlans SVN] opencore r17330)

      from nickyg on May 27, 2008 12:24 PM 
      On May 27, 2008, at 9:17 AM, Rob Miller wrote:
> p.s.: i thought we decided a while ago to de-emphasize the fullname  
> and use the login id as the main token to display for people?  is  
> this still true?

That was true for openplans.org, but on LS.com we want to give people  
the option.  The reasoning is that there is already a large community  
of Sblog and Sfilms commenters, who are pretty split in terms of how  
they represent themselves (real name vs. handle).  So, with the roll  
out of the LSN and permanent identities, we want to make sure people  
can have the choice and maintain continuity with their past  
contributions.

Nick

--
Nick Grossman
The Open Planning Project -- topp.openplans.org
nickyg@...
(917) 825-6590

      • Re: Calculating members' display names (Re: [OpenPlans SVN] opencore r17330)

        from ra on May 27, 2008 01:20 PM 
        On May 27, 2008, at 9:24 AM, Nick Grossman wrote:

>
> On May 27, 2008, at 9:17 AM, Rob Miller wrote:
>>
>> p.s.: i thought we decided a while ago to de-emphasize the fullname  
>> and use the login id as the main token to display for people?  is  
>> this still true?
>
> That was true for openplans.org, but on LS.com we want to give  
> people the option.  The reasoning is that there is already a large  
> community of Sblog and Sfilms commenters, who are pretty split in  
> terms of how they represent themselves (real name vs. handle).  So,  
> with the roll out of the LSN and permanent identities, we want to  
> make sure people can have the choice and maintain continuity with  
> their past contributions.

ah, great, thanks for this info.  ideally, IMO, this would be all be  
encapsulated in the logic of the title field.  "title" is the dublin  
core (and, consequently, Plone) API standard for the human-readable  
representation of a piece of content.  since members are just another  
type of content, i think it makes sense for us to stick w/ this  
convention.  we can build the configurability into the core member  
implementation, and we can choose whether to expose this  
configurability to the users on a site-by-site basis.

-r

    • Re: Calculating members' display names (Re: [OpenPlans SVN] opencore r17330)

      from rmarianski on May 27, 2008 12:40 PM 
      On Tue, May 27, 2008 at 09:17:05AM -0700, Rob Miller wrote:
> On May 27, 2008, at 9:01 AM, Ethan Jucovy wrote:
>
>> On Tue, May 27, 2008 at 11:56 AM,  <rmarianski@...> wrote:
>>> Author: rmarianski
>>> Date: 2008-05-27 11:56:39 -0400 (Tue, 27 May 2008)
>>> New Revision: 17330
>>> Log:
>>> Add support for new function on opencore member objects,
>>> "displayName". This currently shows the full name if it is set, and
>>> falls back to the member id.
>>
>> Doesn't this already exist?  I thought there's an existing field on
>> member objects that is calculated to do exactly this ... though I
>> always forget whether it's Title, Fullname, full_name, or something
>> else...
>
> title is the field that should do this.  fullname is a separate field, 
> which only contains the fullname, no failover to anything else... if it's 
> empty it's empty.
>
> i'm pretty sure this already works... if it doesn't, this is how it should 
> be.
>
> -r

I just checked it, and it does work. I forgot that this existed. Thanks
for watching the commits Ethan. I'll revert the checkin I made that
reproduced this functionality.

-- 
Robert
Return to conversation view