Ross Patterson wrote:
> Rob Miller <robm@...> writes:
> 
>> okay, everyone's made their opinions clear, no problem.  the bottom
>> line, though, is that there will be migration code in the remember
>> product.  i'm planning, early next week, to repurpose the migration
>> code that's currently in personalities as a part of the remember core,
>> probably making a few changes in the process.
> 
> I understand you want everything related to remember to go the way you
> want it to go and that sometimes it's difficut to play with others.
> It's just a shame you find it necessary to override the wishes of
> authors of code you find valuable, especially when there are plenty of
> more cooperative options on the table.

the only other options i see are a) not using the working code you've already 
developed, and instead developing an entirely different migration routine or 
b) forcing people to have to install a separate product in order to get even 
the most basic cmfmember -> remember migration.

option a) is possible, certainly, but seems silly to me; you've written 
working migration code, it's done well enough to be a reasonable starting 
point, i'm not particularly interested in snubbing your contribution and doing 
it again a different way.

you seem to want option b) to be the case.  in fact, the way things are 
currently put together, it's worse than that... people actually have to 
install the 'personalities' profile into their plone site for the migration to 
work.  this means that folks will get two new member types installed, one of 
which adds no functionality to the default remember member type.  folks will 
also have the default registration tool overridden by a custom tool, which 
contains extra methods to support the "ConfirmationMember" type.  this strikes 
me as a supremely bad idea.

personalities could be changed, i realize, so that the migration is still 
usable even w/o forcing people to install the personalities profile.  but i 
don't even see why folks should be forced to HAVE this extra code around if 
they don't need it.

> I wish I had been given a
> chance to respond to any specific problem cases you might have come up
> with that might have demonstrated what was actually wrong with what I
> proposed.

the specific problem is one i've already mentioned: i do not, nor have i ever, 
wanted folks to have to install an additional product in order to get 
CMFMember -> remember migration.  i consider that a core part of what remember 
should deliver.  when you put your migration code in the personalities 
product, and then asked that i leave it there, you put me in an awkward 
position.  either i ignore your code and reimplement a migration from scratch 
(silly), or i compromise remember's migration story by forcing people to 
install non-migration related code in order to get the most basic CMFMember -> 
remember migration working.

neither of those make sense to me.  my attempts to convince you of that were 
unsuccessful; you still seem to think that the latter choice is a good one.  i 
feel strongly enough about this that i'm willing to invoke remember-pope-ness 
to include the migration code in the remember core.  i'm sorry if this upsets 
you, it's not my intent to do so.

> I hope you'll at least properly cite authorship in any code
> you incorporate.

of course, this goes w/o saying.

>> i won't touch personalities, though, per ross's request.  i'll leave
>> the existing migration code in there, even though it will have become
>> redundant (and will possibly be interfering with the other code) at
>> that point.
> 
> I haven't requested that you don't touch personalities.  Please feel
> free to make contributions to personalities.  And if you're going to
> leverage your weight to override my wishes for my migration code, then
> please feel free to make commits that disable any code that conflicts
> with your changes to prevent personalities from breaking.  Just do so
> without *removing* any code.  At any rate, I certainly do wish for you
> or anyone else who wishes to make contributions to "touch"
> personalities.

when you say to do so w/o removing any code, does this mean that you want me 
to leave the vestigial (i.e. unexecuted) code in the product?  you'd rather 
have it come down in an svn checkout, even though it should never be run, than 
have the product only contain actual working code?  you know that the history 
is still preserved in the svn repo, right?

>> if you reconsider, ross, my offer to remove the migration code from
>> personalities all at the same time still stands.
> 
> Thank you for your generous offer.

i'm sorry this has gotten difficult, and i'm sorry if you think i'm not 
playing well with others.  i'm honestly trying to honor (and use) your 
contribution in a way that doesn't compromise remember.

-r