Mark Phillips wrote:
> I have a plone site:
> Plone 2.5.5, 
> CMF-1.6.4, 
> Zope (Zope 2.9.8-final, python 2.4.4, freebsd6), 
> Five 1.4.2, 
> Python 2.4.4 (#2, Sep 26 2007, 13:07:27) [GCC 3.4.6 [FreeBSD]
> 20060305], 
> PIL 1.1.6
> membrane 1.0
> remember 1.0
> 
> I am using a 'simple remember type product to add a couple of fields to
> the join page, and the member_approval_workflow. So far, it all works. 
> 
> I want the reviewer role to be able to approve members, so I went to all
> the states of the member_approval_workflow and checked all the reviewer
> boxes the the manager has checked, thinking that would allow the
> reviewer role to approve new members. However, it did not work. What am
> I missing so the reviewer can approve members? I don't want the
> reviewers to be managers as well.

whether or not you can approve a member is based on the workflow transition 
guards, not the permission settings for a specific state.  you can see this in 
the ZMI if you browse into one of the transitions inside the workflow.

by default, the guard on the "enable_public" transition is the "Manage users" 
permission.  if you give this permission to the Reviewer role at the root of 
your Plone site, then reviewers should be able to approve members.

if this gives too much power to the Reviewers (since the "Manage users" 
permission may have other ramifications as well), then you may need to change 
the guard on the transition, perhaps to explicitly allow Manager and Reviewer 
roles rather than using a permission.

-r