• nymap-dev

  • [NYMap Trac] #337: Refactor Popup Contexts

    from "Vespucci" on Apr 08, 2008 12:13 PM
    #337: Refactor Popup Contexts
    ----------------------+-----------------------------------------------------
     Reporter:  tcoulter  |       Owner:                         
         Type:  defect    |      Status:  new                    
     Priority:  major     |   Milestone:  1.1.0 No Longer Initial
    Component:  FrontEnd  |    Keywords:                         
    ----------------------+-----------------------------------------------------
     We should change the way popup contexts are handled. Right now, we have
     specific popups that are supposed to show certain contexts -- for
     instance, the LoadCommentsPopup or the AddCommentPopup. Unfortunately,
     this implementation, succumbs to all the problems of using different
     popups to perform content changes (like the popup changing size when
     clicking on a tab). It also is out of line with the spirit of the context
     idea, in that you're not looking at a different context, everything else
     being the same; you're instead looking at a totally different popup
     altogether.
    
     What I would propose is a method very similar to what we're using for the
     sidebar. Instead of creating totally different sidebars every time we need
     the content to change, we instead show a different view. This method, when
     applied to popups, abstracts out the frame of the view (i.e., the popup
     that's originally opened), and allows content to change seamlessly without
     providing a jarring experience for the user.
    
    -- 
    Ticket URL: <http://projects.opengeo.org/vespucci/ticket/337>
    Vespucci <http://projects.opengeo.org/vespucci>
    NYC Map
    
    Thread Outline:
  • Re: [NYMap Trac] #337: Refactor Popup Contexts

    from "Vespucci" on Apr 08, 2008 12:15 PM
    #337: Refactor Popup Contexts
    ----------------------+-----------------------------------------------------
     Reporter:  tcoulter  |        Owner:                         
         Type:  defect    |       Status:  new                    
     Priority:  major     |    Milestone:  1.1.0 No Longer Initial
    Component:  FrontEnd  |   Resolution:                         
     Keywords:            |  
    ----------------------+-----------------------------------------------------
    Description changed by tcoulter:
    
    Old description:
    
    > We should change the way popup contexts are handled. Right now, we have
    > specific popups that are supposed to show certain contexts -- for
    > instance, the LoadCommentsPopup or the AddCommentPopup. Unfortunately,
    > this implementation, succumbs to all the problems of using different
    > popups to perform content changes (like the popup changing size when
    > clicking on a tab). It also is out of line with the spirit of the context
    > idea, in that you're not looking at a different context, everything else
    > being the same; you're instead looking at a totally different popup
    > altogether.
    >
    > What I would propose is a method very similar to what we're using for the
    > sidebar. Instead of creating totally different sidebars every time we
    > need the content to change, we instead show a different view. This
    > method, when applied to popups, abstracts out the frame of the view
    > (i.e., the popup that's originally opened), and allows content to change
    > seamlessly without providing a jarring experience for the user.
    
    New description:
    
     We should change the way popup contexts are handled.
    
     Right now, we have specific popups that are supposed to show certain
     contexts -- for instance, the LoadCommentsPopup or the AddCommentPopup.
     Unfortunately, this implementation succumbs to all the problems of using
     different popups to perform content changes (like the popup changing size
     when clicking on a tab). It also is out of line with the spirit of the
     context '''idea''', in that you're not looking at a different context,
     everything else being the same; you're instead looking at a totally
     different popup altogether.
    
     What I would propose is a method very similar to what we're using for the
     sidebar. Instead of creating totally different sidebars every time we need
     the content to change, we instead show a different view. This method, when
     applied to popups, abstracts out the frame of the view (i.e., the popup
     that's originally opened), and allows content to change seamlessly without
     providing a jarring experience for the user.
    
    --
    
    -- 
    Ticket URL: <http://projects.opengeo.org/vespucci/ticket/337#comment:1>
    Vespucci <http://projects.opengeo.org/vespucci>
    NYC Map
    
  • Re: [NYMap Trac] #337: Refactor Popup Contexts

    from "Vespucci" on Apr 08, 2008 01:42 PM
    #337: Refactor Popup Contexts
    ----------------------+-----------------------------------------------------
     Reporter:  tcoulter  |        Owner:                         
         Type:  defect    |       Status:  new                    
     Priority:  major     |    Milestone:  1.1.0 No Longer Initial
    Component:  FrontEnd  |   Resolution:                         
     Keywords:            |  
    ----------------------+-----------------------------------------------------
    
    Comment(by tcoulter):
    
     From the channel:
    
     {{{
     <funky_c> rpenate: What do you need to get out of popup contexts? From a
     UI point of view, is there some way we can (re)design those to help you
     out?
     <rpenate> funky_c: what do you mean?
     <funky_c> rpenate: I'm saying you have a say in how the context stuff
     should be structurally designed. For instance, are there certain ways we
     should id our tabs? Should we use certain classes? Is there something
     related to how we code this stuff that will eventually make your job
     easier in the future?
      I'm likely going to start working on this soon:
     http://projects.opengeo.org/vespucci/ticket/337
     <rpenate> funky_c: probably not anything i could be very proactive about
     <funky_c> Got it. Cool.
      Right now, I don't believe our popups as being anywhere close to where
     you'd like them to be. While cleaning up things after the merge, I figured
     I'd get the above ticket done as well.
      rpenate: Actually, if you can read the above ticket, I'd appreciate it.
     Our popups do a lot of weird things because when you click on a tab,
     you're actually viewing a totally new popup (rather than having a tabbed
     interface that changes the content). If you think the oddities are okay in
     the long term, then I'll find something else to work on.
     <rpenate> funky_c: that ticket makes sense
      funky_c: regenerating pop-ups feels kinda gross
     <funky_c> Ya, that's what I thought.
     }}}
    
    -- 
    Ticket URL: <http://projects.opengeo.org/vespucci/ticket/337#comment:2>
    Vespucci <http://projects.opengeo.org/vespucci>
    NYC Map
    
  • Re: [NYMap Trac] #337: Refactor Popup Contexts

    from "Vespucci" on Apr 08, 2008 03:27 PM
    #337: Refactor Popup Contexts
    ----------------------+-----------------------------------------------------
     Reporter:  tcoulter  |        Owner:                         
         Type:  defect    |       Status:  new                    
     Priority:  major     |    Milestone:  1.1.0 No Longer Initial
    Component:  FrontEnd  |   Resolution:                         
     Keywords:            |  
    ----------------------+-----------------------------------------------------
    
    Comment(by tcoulter):
    
     First wave: [728]. See commit message.
    
    -- 
    Ticket URL: <http://projects.opengeo.org/vespucci/ticket/337#comment:3>
    Vespucci <http://projects.opengeo.org/vespucci>
    NYC Map
    
  • Re: [NYMap Trac] #337: Refactor Popup Contexts

    from "Vespucci" on Apr 09, 2008 02:24 PM
    #337: Refactor Popup Contexts
    ----------------------+-----------------------------------------------------
     Reporter:  tcoulter  |        Owner:  tcoulter               
         Type:  defect    |       Status:  new                    
     Priority:  major     |    Milestone:  1.1.0 No Longer Initial
    Component:  FrontEnd  |   Resolution:                         
     Keywords:            |  
    ----------------------+-----------------------------------------------------
    Changes (by sbenthall):
    
      * owner:  => tcoulter
    
    
    -- 
    Ticket URL: <http://projects.opengeo.org/vespucci/ticket/337#comment:4>
    Vespucci <http://projects.opengeo.org/vespucci>
    NYC Map