On Jan 4, 2008 10:37 AM, Tim Hicks <tim@...> wrote:
> Derek Richardson wrote:
>
> >> See my checkin at <http://dev.plone.org/collective/changeset/56326>.
> >> Advice on appropriate tests would be welcome.
> >
> > Looked at it briefly. Will try it as soon as I can get to it.
> >
> > Currently, the tests simply look on the page for the links in the
> > viewlet. Your new tests (functional only, right now) should simply put
> > a portlet on a page and try to access the links and see if the feed is
> > correct. I hate to inflict our tests on you, as they are messy, but,
> > if you're willing to wade through them, I'd love to have tests written
> > for the portlet.
>
> Wow, I'm struggling to understand the test framework in place for
> p.[a.]s.o.  I started off subclassing testFunctional.TestPloneFeeds, but
> that turned out to be over-kill as it comes with test methods for all
> the different feed types.

Yah, sorry, it *is* ugly.

> I'm pasting the test module I've written so far.  It doesn't work yet
> because I don't know how to write the 'setupFeedConfigFor' method and
> have run out of time to work on this at the moment.  For some reason,

You should copy p.a.s.o.tests.testFunctional.TestPloneFeeds.feed()

> tests are taking about 12-15 minutes to run on my laptop, which makes
> progress here *very* slow :(.

Combinatorial explosion of the testing procedure. Yes, they take a
long time even on my quadcore. Needs to be fixed.0

> Can someone advise on what I should have for the setupFeedConfigFor
> method (which would be analogous to the TestPloneFeeds.feed method, only
> without doing it through the adminBrowser but rather normal code)?

Ah, now I see the problem. Why no admin browser? You can use it. If ya
wanna really configure a feed by hand, look at the feed() method in:

http://dev.plone.org/collective/browser/Vice/trunk/plone.syndication.outbound/plone/syndication/outbound/tests/basefunctional.py?rev=51711

We moved away from under-the-covers to the admin browser to achieve
greater test coverage.

>
> Tim
>
> p.s.  I forgot to mention, before I started doing any of this work for
> the feedlinks portlet, I was seeing failing tests for plone.syndication.


Yep. p.s.o tests fail. As long as p.a.s.o tests pass, we're golden.
p.s.o gets thoroughly exercised in the p.a.s.o tests, but we just
aren't supporting z3 atm - writing p.s.o tests that work in z2 without
plone and z3 was just too hard and no on was itching.

>
> # Zope imports
> from zope.component import getUtility
> from zope.app.container.interfaces import INameChooser
> from Products.Five import zcml
> try:
>   from Products.Five.testbrowser import Browser
> except ImportError:
>   from zope.testbrowser.testing import Browser
>
> # Plone imports
> from plone.portlets.interfaces import IPortletAssignmentMapping
> from plone.app.portlets.utils import assignment_mapping_from_key
> from Products.CMFCore.utils import getToolByName
> from Products.PloneTestCase.PloneTestCase import FunctionalTestCase
>
> # Local test imports
> from testFunctional import TestPloneFeeds
> from testFunctional import createTestEmptyDir
>
> # Local implementation imports
> from plone.app.syndication.outbound.portlets import feedlinks
>
>
> class TestFeedLinkPortlet(FunctionalTestCase):
>     """Test case for the FeedLinks portlet.
>     """
>
>     def afterSetUp(self):
>         zcml.load_site()
>         self.loginAsPortalOwner()
>         self.folder = folder = createTestEmptyDir(self.portal, 'atom')
>         self.browser = self._getBrowser()
>         self.setupFeedConfigFor(folder, name='fooname', format='atom')
>         self.addPortletTo(folder)
>
>     def _getBrowser(self):
>         return Browser()
>
>     def setupFeedConfigFor(self, folder, format):
>         # XXX Help!
>         pass
>
>     def addPortletTo(self, folder):
>         left = getUtility(IPortletManager, name='plone.leftcolumn')
>         folder_left_portlets = getMultiAdapter((folder, left),
>                                                IPortletAssignmentMapping)
>         assignment = feedlinks.Assignment()
>         chooser = INameChooser(folder_left_portlets)
>         folder_left_portlets[chooser.chooseName(None, assignment)] =
> assignment
>
>     def test_PortletPresent(self):
>         self.browser.open(self.folder.absolute_url())
>         self.failUnless('portletFeedLinks' in self.browser.contents)
>
>
> def test_suite():
>     from unittest import TestSuite, makeSuite
>     suite = TestSuite()
>     suite.addTest(makeSuite(TestFeedLinkPortlet))
>     return suite
>
>
> --
> Archive: http://www.openplans.org/projects/vice/lists/vice-squad/archive/2008/01/1199461104158
>
> To unsubscribe send an email with subject unsubscribe to vice-dev@....  Please contact vice-dev-manager@... for questions.
>